fix: resolve production bugs, improve code quality, and add test suite - #8
Open
olcar wants to merge 1 commit into
Open
fix: resolve production bugs, improve code quality, and add test suite#8olcar wants to merge 1 commit into
olcar wants to merge 1 commit into
Conversation
olcar
commented
Jul 7, 2026
- Fix PATCH data corruption (originPlanet/character undefined queries)
- Fix DELETE soft-delete (was a no-op for characters)
- Fix auth typo (acces_token → access_token)
- Strip password hash from register response
- Remove 10-day Cache-Control on API responses
- Remove X-Powered-By header
- Fix ESLint config and remove 12 unused imports
- Add synchronization warnings for production
- Add .env.example for easier onboarding
- 28 unit tests across all 4 services
- 4 e2e tests replacing broken placeholder
- Rewrite README with project-specific documentation
- Fix PATCH data corruption (originPlanet/character undefined queries) - Fix DELETE soft-delete (was a no-op for characters) - Fix auth typo (acces_token → access_token) - Strip password hash from register response - Remove 10-day Cache-Control on API responses - Remove X-Powered-By header - Fix ESLint config and remove 12 unused imports - Add synchronization warnings for production - Add .env.example for easier onboarding - 28 unit tests across all 4 services - 4 e2e tests replacing broken placeholder - Rewrite README with project-specific documentation
Author
|
Hello! Please let me know what you think of those improvements suggestions :) |
Owner
|
Thanks for the contribution. The PATCH/DELETE fixes match the API’s original behavior and the unit tests pass. Before merging, could you fix and test Once that case is covered, this should be ready from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.