Skip to content

fix: resolve production bugs, improve code quality, and add test suite - #8

Open
olcar wants to merge 1 commit into
intentodepirata:masterfrom
olcar:dev/olcar
Open

fix: resolve production bugs, improve code quality, and add test suite#8
olcar wants to merge 1 commit into
intentodepirata:masterfrom
olcar:dev/olcar

Conversation

@olcar

@olcar olcar commented Jul 7, 2026

Copy link
Copy Markdown
  • Fix PATCH data corruption (originPlanet/character undefined queries)
  • Fix DELETE soft-delete (was a no-op for characters)
  • Fix auth typo (acces_token → access_token)
  • Strip password hash from register response
  • Remove 10-day Cache-Control on API responses
  • Remove X-Powered-By header
  • Fix ESLint config and remove 12 unused imports
  • Add synchronization warnings for production
  • Add .env.example for easier onboarding
  • 28 unit tests across all 4 services
  • 4 e2e tests replacing broken placeholder
  • Rewrite README with project-specific documentation

- Fix PATCH data corruption (originPlanet/character undefined queries)
- Fix DELETE soft-delete (was a no-op for characters)
- Fix auth typo (acces_token → access_token)
- Strip password hash from register response
- Remove 10-day Cache-Control on API responses
- Remove X-Powered-By header
- Fix ESLint config and remove 12 unused imports
- Add synchronization warnings for production
- Add .env.example for easier onboarding
- 28 unit tests across all 4 services
- 4 e2e tests replacing broken placeholder
- Rewrite README with project-specific documentation
@olcar

olcar commented Jul 7, 2026

Copy link
Copy Markdown
Author

Hello! Please let me know what you think of those improvements suggestions :)

@intentodepirata

Copy link
Copy Markdown
Owner

Thanks for the contribution. The PATCH/DELETE fixes match the API’s original behavior and the unit tests pass.

Before merging, could you fix and test isDestroyed with multipart/form-data? Form-data sends values such as "false" as strings, while the DTO now requires a runtime boolean, so valid create/update requests may be rejected.

Once that case is covered, this should be ready from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants