Skip to content

Fix delete/delete[] mismatches and off-by-one null terminator #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidchatting merged 1 commit into from
Aug 5, 2026
Merged

Fix delete/delete[] mismatches and off-by-one null terminator #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/YoYoWiFiManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ void YoYoWiFiManager::addKnownNetworks() {
settings -> getPassword(n, password);
addNetwork(ssid, password, false);
}
delete ssid, password;
delete[] ssid;
delete[] password;
}
}

Expand All @@ -192,7 +193,7 @@ bool YoYoWiFiManager::addNetwork(char const *ssid, char const *password, bool sa
else {
Serial.println("can't wifiMulti.addAP()");
}
delete matchingSSID;
delete[] matchingSSID;
}
}

Expand Down Expand Up @@ -263,7 +264,8 @@ uint8_t YoYoWiFiManager::loop() {
getStatusAsString(currentStatus, currentStatusString);
getStatusAsString(yyStatus, yyStatusString);
Serial.printf("STATUS: %s\t>\t%s\n", currentStatusString, yyStatusString);
delete currentStatusString, yyStatusString;
delete[] currentStatusString;
delete[] yyStatusString;

switch(yyStatus) {
case YY_CONNECTED:
Expand Down Expand Up @@ -387,7 +389,8 @@ bool YoYoWiFiManager::updateMode() {
getModeAsString(currentMode, currentModeString);
getModeAsString(nextMode, nextModeString);
Serial.printf("MODE:\t%s\t>\t%s\n", currentModeString, nextModeString);
delete currentModeString, nextModeString;
delete[] currentModeString;
delete[] nextModeString;

switch(nextMode) {
case YY_MODE_NONE:
Expand Down Expand Up @@ -855,7 +858,7 @@ int YoYoWiFiManager::onYoYoRequestPOST(uint8_t *data, size_t len, AsyncWebServer
len = min(len, (unsigned int) 1024-1);
int i = 0;
for (; i < len; i++) json[i] = char(data[i]);
json[i+1] = '\0';
json[i] = '\0';

DynamicJsonDocument message(1024);
DynamicJsonDocument payload(1024);
Expand All @@ -873,7 +876,7 @@ int YoYoWiFiManager::onYoYoRequestPOST(uint8_t *data, size_t len, AsyncWebServer
result = 400;
}

delete json;
delete[] json;
}
else if(request -> contentType().equals("multipart/form-data")) {
//FILE UPLOAD
Expand Down Expand Up @@ -1159,7 +1162,8 @@ void YoYoWiFiManager::getCredentialsAsJson(JsonDocument& jsonDoc) {
network["password"] = password;
if(n == lastNetwork) network["lastnetwork"] = true;
}
delete ssid, password;
delete[] ssid;
delete[] password;
}
}

Expand Down Expand Up @@ -1255,7 +1259,7 @@ void YoYoWiFiManager::getPeersAsJson(JsonDocument& jsonDoc) {
if(localIPAddress) delete localIPAddress;

delete ipAddress;
delete macAddress;
delete[] macAddress;
}

bool YoYoWiFiManager::getPeerN(int n, IPAddress *ipAddress, uint8_t *macAddress) {
Expand Down Expand Up @@ -1298,7 +1302,7 @@ void YoYoWiFiManager::createNestedPeer(JsonDocument& jsonDoc, IPAddress *ip, uin
char *macAddressAsCStr = new char[18];
mac_addr_to_c_str(macAddress, macAddressAsCStr);
peer["MAC"] = macAddressAsCStr;
delete macAddressAsCStr;
delete[] macAddressAsCStr;

if(localhost) peer["LOCALHOST"] = true;
if(gateway) peer["GATEWAY"] = true;
Expand Down Expand Up @@ -1369,8 +1373,8 @@ void YoYoWiFiManager::getClientsAsJson(JsonDocument& jsonDoc) {
client["MAC"] = macAddress;
}

delete ipAddress;
delete macAddress;
delete[] ipAddress;
delete[] macAddress;
}
else if(currentMode == YY_MODE_PEER_CLIENT) {
//Empty
Expand Down
Loading