execute mesh networking pre-exec script instead of inlining it#27
Open
Sam6734 wants to merge 1 commit into
Open
execute mesh networking pre-exec script instead of inlining it#27Sam6734 wants to merge 1 commit into
Sam6734 wants to merge 1 commit into
Conversation
Signed-off-by: Sam <55770131+Sam6734@users.noreply.github.com>
Sam6734
force-pushed
the
feat/mesh-networking-support
branch
from
0ae49e0 to
83bacbd
Compare
Member
|
@Sam6734 thank you for the contribution! While I'm reviewing it, do you tested it with the full mesh setup or for the "port forwarding"-only pattern? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the plugin pasted the mesh setup script directly into the container launch command. Bash interpreted that wrong, and the job only ran cat to write mesh.sh, then it exited successfully without running the real container workload breaking things.