Skip to content

Strips URL params before sending URL to pipeline #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DecentralizedDan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Strips URL params before sending URL to pipeline #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion source/predicates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Predicates."""
import requests
import re
from urllib.parse import urlparse

from utility import urls_from_str, backend_base_url, backend_api_key
from model import AllowDomain
Expand All @@ -21,10 +22,14 @@ def str_contains_url_p(str):


def url_malicious_p(url):
"""Strip URL parameters to protect sensitive user information"""
url = urlparse(url)

@jmercouris jmercouris Jan 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail on malformed URLs!

netloc = url.netloc

"""Return True or False depending on whether a URL is malicious or not."""
json_payload = {
"key": backend_api_key,
"url": url
"url": netloc
}

r = requests.post(
Expand Down