Refactor OPDS links and update catalog metadata#11510
Closed
mekarpeles wants to merge 2 commits intomasterfrom
Closed
Refactor OPDS links and update catalog metadata#11510mekarpeles wants to merge 2 commits intomasterfrom
mekarpeles wants to merge 2 commits intomasterfrom
Conversation
Switch to pyopds2_openlibrary.STORED_SEARCHES which uses pyopds2.Search
for more information, see https://pre-commit.ci
Member
Author
|
Code to be moved to https://github.com/archivelabs/opds.openlibrary.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to
pyopds2_openlibrary.STORED_SEARCHESArchiveLabs/pyopds2_openlibrary#18 which usespyopds2.Search(ArchiveLabs/pyopds2@7b42424)This PR is not complete.
This pull request refactors and improves the OPDS API endpoints in
openlibrary/plugins/openlibrary/api.py. The main changes focus on making the code more modular, reducing duplication, and introducing a new subject-based OPDS endpoint. The update also streamlines how bookshelf and profile links are added, and centralizes the logic for featured subject navigation and stored searches.Key changes:
Refactoring and Code Simplification:
Linkobjects with calls toprovider.bookshelf_link()andprovider.profile_link, making the code more modular and easier to maintain. [1] [2]New Features:
opds_subjectsendpoint (/opds/subjects/<subject_key>) that returns an OPDS catalog for a given subject using search parameters tailored for trending, borrowable books, and safe-for-work content.Homepage and Navigation Improvements:
provider.STORED_SEARCHESlist, simplifying the logic for generating trending, classic, romance, kids, thrillers, and textbooks sections.