Catch StopIteration raised by generator#7
Open
mamciek wants to merge 1 commit intointernetarchive:masterfrom
Open
Catch StopIteration raised by generator#7mamciek wants to merge 1 commit intointernetarchive:masterfrom
mamciek wants to merge 1 commit intointernetarchive:masterfrom
Conversation
Contributor
|
Hi @mamciek ! I can't test the client on Python 3.7 now, but I should be able to do it soon. In the meantime, can you please add the full stacktrace that you get? I am not familiar with the code of client.py so I'd like to make sure to understand what _ha_gen_method does exactly. @nlevitt you have more experience so if the patch looks trivial/ok-to-merge it might be a good candidate for a new minor version of snakebite? |
|
can you make a minor version to support python >= 3.7 please ? 😄
here is the stacktrace : |
Contributor
|
@nlevitt hi! This is probably a good use case for a quick release if you have time during the next days :) |
|
Any chance that this will get merged and released in the near future? |
vijay-jangir
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on python 3.7+ then generator raises
StopIterationexceptionThis expected according to https://docs.python.org/3/whatsnew/3.7.html#changes-in-python-behavior