refactor(tui): Major restructuring#55
Closed
Udayan853 wants to merge 4 commits intointerpretive-systems:mainfrom
Closed
refactor(tui): Major restructuring#55Udayan853 wants to merge 4 commits intointerpretive-systems:mainfrom
Udayan853 wants to merge 4 commits intointerpretive-systems:mainfrom
Conversation
- Moved wizards to a seperate package - Introduced `Wizard` interface for consistency - Refactored the key press management into `keys.go` with action constants - Extracted UI components to `internal/tui/components` - Added `commands.go` to unify gitx function calls - Moved the search functionality to a new `search` package - Moved theme to a different package to avoid circular dependencies
- Refactored fix to account for latest file structure changes
- Refactored `program_test.go` to account for file structure changes
Contributor
|
Let's handle this differently after Hacktoberfest since right now there a lot of changes going on and this will require me to do a lot of checks before merging. Feel free to pick a simpler issue from the issues list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wizardinterface for consistencykeys.gowith action constantsinternal/tui/componentscommands.goto unifygitxfunction callssearchpackageSummary
This PR modularizes
program.goand related functionality to enhance readability, maintainability, and logical separation of concerns.I have tested the functionality end-to-end, but since this is a major refactor, it will benefit from a thorough review.
Note: unit tests will need to be rewritten to reflect the new structure.
Linked Issue(s)
Significant Progress on #18
Checklist
go buildandgo test ./...