Skip to content

fix display of branch names with special characters#956

Merged
isc-pbarton merged 4 commits intomainfrom
fix-branch-names
May 5, 2026
Merged

fix display of branch names with special characters#956
isc-pbarton merged 4 commits intomainfrom
fix-branch-names

Conversation

@isc-pbarton
Copy link
Copy Markdown
Collaborator

@isc-pbarton isc-pbarton commented Apr 14, 2026

Fixes #914

Testing plan

docker compose exec iris iris session iris
do ##class(SourceControl.Git.API).Configure() to initialize a git repository
docker compose exec iris bash
cd /usr/irissys/mgr/repo/USER
git branch "invalid#branch"

load the web ui: http://localhost:52774/isc/studio/usertemplates/gitsourcecontrol/webuidriver.csp/USER/

  • the branch list in the left panel should show a warning message that there is a branch with unsupported characters.
  • I should be able to create new branches with the supported characters.
  • I should not be able to create new branches with the unsupported characters, and I should get a descriptive error message if I try.

@isc-pbarton
Copy link
Copy Markdown
Collaborator Author

CI failing I think because of changes in the intersystemsdc/iris-community:latest image. Fails to install TestCoverage. When I run locally on the same base image I get an error that no IPM registries are configured.

@isc-dchui
Copy link
Copy Markdown
Collaborator

Hm I'm not fully convinced we should necessarily support the "#" character (or spaces) in branch names. I feel like as long as we support this we're fine.

@isc-pbarton
Copy link
Copy Markdown
Collaborator Author

After discussion with @isc-dchui, we decided that just supporting pound sign is kind of arbitrary, but we want to keep the web UI simple rather than supporting everything. Plan is:

  • support smaller set of branch names matching this default set
  • add branch name validation when you create a new branch, both in web UI and source control menus
  • exclude unsupported branch names from web UI, and show warning message if more branches exist with unsupported names. this keeps us reasonably compatible with other git clients

@isc-pbarton isc-pbarton marked this pull request as draft April 15, 2026 14:00
@isc-pbarton isc-pbarton marked this pull request as ready for review April 16, 2026 18:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.10%. Comparing base (ee80d7f) to head (d2eaff4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   49.05%   49.10%   +0.04%     
==========================================
  Files          23       23              
  Lines        3284     3287       +3     
==========================================
+ Hits         1611     1614       +3     
  Misses       1673     1673              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@isc-dchui isc-dchui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing and a question about testing. What kind of testing did you do for this change?

Comment thread git-webui/release/share/git-webui/webui/js/git-webui.js Outdated
@isc-pbarton isc-pbarton merged commit 5d1b869 into main May 5, 2026
2 checks passed
@isc-pbarton isc-pbarton deleted the fix-branch-names branch May 5, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branch not displaying in GitUI

3 participants