fix display of branch names with special characters#956
Conversation
|
CI failing I think because of changes in the intersystemsdc/iris-community:latest image. Fails to install TestCoverage. When I run locally on the same base image I get an error that no IPM registries are configured. |
|
Hm I'm not fully convinced we should necessarily support the "#" character (or spaces) in branch names. I feel like as long as we support this we're fine. |
|
After discussion with @isc-dchui, we decided that just supporting pound sign is kind of arbitrary, but we want to keep the web UI simple rather than supporting everything. Plan is:
|
3f71196 to
6645dcb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 49.05% 49.10% +0.04%
==========================================
Files 23 23
Lines 3284 3287 +3
==========================================
+ Hits 1611 1614 +3
Misses 1673 1673 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-dchui
left a comment
There was a problem hiding this comment.
Just one thing and a question about testing. What kind of testing did you do for this change?
…back end branch validation
…trol into fix-branch-names
Fixes #914
Testing plan
docker compose exec iris iris session iris
do ##class(SourceControl.Git.API).Configure() to initialize a git repository
docker compose exec iris bash
cd /usr/irissys/mgr/repo/USER
git branch "invalid#branch"
load the web ui: http://localhost:52774/isc/studio/usertemplates/gitsourcecontrol/webuidriver.csp/USER/