Conversation
isc-tleavitt
left a comment
There was a problem hiding this comment.
I want to discuss this in our next IPM meeting.
I think the effect of this will be that zpm "install" of the same package will upgrade Python dependencies based on semvers in requirements.txt where previously it wouldn't unless you specifically told it to.
Other possible concern - running processes while the install runs. But that's probably an issue any time your upgrading even without explicitly deleting directory chains first - possibly something that could be addressed in a venv-ish solution.
This is tied to the challenges with Python dependency management more generally.
Especially where our target here is fixing CI problems, I'm hesitant to take on a significant user facing change as part of it. But we shouldn't need to solve the whole pseudo-venv / python dependency management problem; maybe this is a reasonable incremental step.
Description
test/verifycalls, e.g. in the scopes integration test, we callscope-test verify -only, so whenzpm verify -onlyis called, we end up nesting.^||%UnitTest.Manager.LastResultto track test runs. This iskilled at the start of the running of tests, which causes problems with nesting: the parent's results are killed by the child^||%UnitTest.Manager.AllResultsCountthat collates individual instantiations.ScopesandFileCopy.^||%UnitTest.Manager.LastResulthas been completely removed since IPM will no longer use it, so any custom code built on top of this will breakTesting
Ran
zpm verify -onlyand the tests pass. Also made sure if there is a failing test, theverifyphase will correctly fail. For nested tests, made sure that if the nested test fails, it will be properly reported in the summary at the end.Checklist
mainbranch rebased or merged.zpm test -only) and integration tests (zpm verify -only) pass.