Fix: IPM Update Resource Conflict#1129
Open
isc-jlechtne wants to merge 4 commits intomainfrom
Open
Conversation
isc-jlechtne
requested review from
isc-cborbonm,
isc-dchui,
isc-egabhart,
isc-eneil,
isc-jili,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-cborbonm
reviewed
May 5, 2026
Collaborator
isc-cborbonm
left a comment
isc-cborbonm
left a comment
There was a problem hiding this comment.
just left a couple of comments! but it looks great to me 😃
| @@ -1371,6 +1364,12 @@ Method GetResolvedReferences( | |||
| } | |||
|
|
|||
| if pLockedDependencies { | |||
Collaborator
There was a problem hiding this comment.
question: why did this get moved to only when pLockedDependencies is set?
| /// See property description for more details on the usage of MarkedForUpdate | ||
| ClassMethod MarkResourceForUpdate( | ||
| resourceName As %String, | ||
| marking As %Boolean = 1) |
Collaborator
There was a problem hiding this comment.
is there a use case for this method when marking would be set to 0?
Collaborator
|
@isc-jlechtne mind adding your test cases to the PR description? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1128