Conversation
isc-dchui
requested review from
isc-cborbonm,
isc-egabhart,
isc-eneil,
isc-jili,
isc-jlechtne,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-kiyer
requested changes
May 11, 2026
Collaborator
isc-kiyer
left a comment
isc-kiyer
left a comment
There was a problem hiding this comment.
@isc-dchui some small questions
| set tVerbose = $get(pParams("Verbose")) | ||
|
|
||
| // Check base IPM install location | ||
| set ipmBaseDir = ##class(%Library.File).NormalizeDirectory(##class(%SYSTEM.Util).DataDirectory() _ "ipm") |
Collaborator
There was a problem hiding this comment.
Don't we have a macro/a setting to be configured for the ipmDir? we should use that right?
| set extension = $$$lcase($piece(tDirectoryName,".",*)) | ||
| if ##class(%File).Exists(tDirectoryName) && ((extension="tgz") || (extension="tar.gz")) { | ||
| set tTargetDirectory = $$$FileTempDirSys | ||
| if tTargetDirectory = ("-" _ -tTargetDirectory) { |
Collaborator
There was a problem hiding this comment.
Can you explain this if condition? Its a little odd to see negation of what seems like it should be a string? Is it an integer when there is no permission?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
installandloadcommand.Testing
Manually tested by changing the permissions of the
/usr/irissys/ipmdirectory and verifying the error appears when trying to install.Checklist
mainbranch rebased or merged.zpm test -only) and integration tests (zpm verify -only) pass.