Skip to content

feat: update dotted statements, make nodes more descriptive#40

Merged
davem-intersys merged 1 commit intointersystems:mainfrom
hkimura-intersys:v1.7.13-updates
Apr 27, 2026
Merged

feat: update dotted statements, make nodes more descriptive#40
davem-intersys merged 1 commit intointersystems:mainfrom
hkimura-intersys:v1.7.13-updates

Conversation

@hkimura-intersys
Copy link
Copy Markdown
Collaborator

Key Changes:

  1. Keyword naming -- the keywords within the legacy version of statements is labeled with _old to make it easy to query these statements to refactor them.
  2. Made the dot within dotted statements an actual node -- this is helpful for querying/refactoring.
  3. Fixed dotted statements edge case

Dotted Statements Edge Case

There was an edge case, that was caused really by a scanner error, that made it so rather than producing a termination, the dots in a dotted statement were eaten. This error was found in this example:

i x = 2 d  d okay set x = 2
 . set x = 1.2
 . set y = 1.2
 . w !,"goodbye" d
 . . new x
 . . set x = 250
 . . w !, x 
 . . quit
 . quit

The scanner has been adjusted, and this issue is now resolved with this PR.

@hkimura-intersys hkimura-intersys self-assigned this Apr 27, 2026
@davem-intersys davem-intersys merged commit 4284929 into intersystems:main Apr 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants