Remove attached document fields and add new terms#22
Open
alvarolivie wants to merge 6 commits intomainfrom
Open
Remove attached document fields and add new terms#22alvarolivie wants to merge 6 commits intomainfrom
alvarolivie wants to merge 6 commits intomainfrom
Conversation
Correct field paths to match actual library implementations: - BT-9/20: fix payment terms paths - BT-17/18: separate tender vs object identifier correctly - BT-25/26: use specific series+code paths for preceding reference - BT-29/30/32/46/47/60/61: clarify scope and ext usage - BT-71: delivery location identifiers - BT-81/82: payment means code uses ext, not key - BT-87/88: card last4 and holder field names - BT-105/128/156: charge reason code, line object ID, buyer item ID - BT-115/116-121: payable field and rates[] level in VAT breakdown - BT-124: url not uri for attachment location - BT-158/159: item classification via identity label - BG-32: fix typo from BR-32 - Add missing BT-125, BT-147-150 entries - Remove BT-4 (withdrawn from standard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive accuracy fixes to the EN16931 terms mapping file, correcting paths and notes to match what the CII and UBL libraries actually implement.
Path corrections: BT-9, BT-20, BT-25, BT-71, BT-81, BT-82, BT-87, BT-88, BT-115, BT-116–121, BT-124, BT-158/159
New entries: BT-125 (attached document), BT-147–150 (price details)
Notes updated: BT-29/30/32/46/47/60/61 (scope/ext usage), BT-85 (CII omits account name), BT-90 (UBL SEPA party approach), BT-105 (re-enabled), BT-120 (mapping TBD), BT-126 (auto-generated), BT-128/156 (now implemented)
Other fixes: Removed BT-4 (withdrawn), fixed BG-32 typo, separated BT-10/18 correctly