Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing you wouldn't add yourself in a couple of minutes, just wanted to explain some things that I tried which didn't work out:
It should be distributed like this:
In CSS, this can be accomplished through
text-wrap: balance. Unfortunately Prince does not support it.I believe text-overflow: ellipsis will do more harm than unbalanced watermark lines. If you have the need of displaying text in a large obvious format you most likely want it displayed in full. Still, it would be a good practice to set a character limit on the input itself.
There's an official fittext script but...
Sounds computationally expensive and we can't preview how it will look without generating the PDF.
All in all, I think the best we can do is assign a class depending on string length, as you suggested.