Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an ARCA document-type indicator (letter + code) to the invoice header for Argentinian documents by reading the ar-arca-doc-type tax extension, and updates header markup/styles plus examples to reflect the new layout.
Changes:
- Introduce
ARCADocTypeLettercomponent (AR regime) that derives letter A/B/C from the ARCA doc-type extension and renders the header “letter box”. - Update the generic title hero markup to always wrap the supplier logo/text in an
.aliascontainer and include the ARCA doc-type component. - Add CSS for the ARCA doc-type box and refresh example outputs / add new AR example fixture.
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/out/us-invoice.html | Updates header markup to wrap logo in .alias. |
| examples/out/full-invoice.html | Updates header markup to wrap logo in .alias. |
| examples/out/full-invoice.adjustment.html | Updates header markup to wrap logo in .alias. |
| examples/out/full-invoice-ar.html | Updates header markup to wrap logo in .alias. |
| examples/out/ar-arca-standard.html | Adds ARCA doc-type “letter box” to rendered example output. |
| examples/out/ar-arca-standard-logo.html | New rendered example output including logo + ARCA doc-type. |
| examples/ar-arca-standard-logo.json | New example input fixture containing ar-arca-doc-type extension + logo. |
| components/regimes/ar/arca.templ | Adds ARCADocTypeLetter templ component + helper to map doc type → A/B/C. |
| components/regimes/ar/arca_templ.go | Generated output for the above templ changes. |
| components/bill/invoice.templ | Adjusts titleHero to accept internal.Document, wraps supplier logo/text in .alias, and renders ARCA doc-type component. |
| components/bill/invoice_templ.go | Generated output for the above invoice templ changes. |
| assets/styles/invoice.css | Makes .hero flex, makes .alias flex-grow, and adds styles for .arca-doc-type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@pmenendz I deliberately changed the markup so if an invoice has a logo, it will still be contained within the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ARCA document type by letter to the PDF invoice. Regulation says it should be clearly stated in the center top of the invoice and this is our adaptation, the convention is shown as a comparison.