Skip to content

ARCA document type letter#86

Open
methodofaction wants to merge 1 commit intomainfrom
arca-tipo
Open

ARCA document type letter#86
methodofaction wants to merge 1 commit intomainfrom
arca-tipo

Conversation

@methodofaction
Copy link
Contributor

This PR adds the ARCA document type by letter to the PDF invoice. Regulation says it should be clearly stated in the center top of the invoice and this is our adaptation, the convention is shown as a comparison.

image image

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an ARCA document-type indicator (letter + code) to the invoice header for Argentinian documents by reading the ar-arca-doc-type tax extension, and updates header markup/styles plus examples to reflect the new layout.

Changes:

  • Introduce ARCADocTypeLetter component (AR regime) that derives letter A/B/C from the ARCA doc-type extension and renders the header “letter box”.
  • Update the generic title hero markup to always wrap the supplier logo/text in an .alias container and include the ARCA doc-type component.
  • Add CSS for the ARCA doc-type box and refresh example outputs / add new AR example fixture.

Reviewed changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
examples/out/us-invoice.html Updates header markup to wrap logo in .alias.
examples/out/full-invoice.html Updates header markup to wrap logo in .alias.
examples/out/full-invoice.adjustment.html Updates header markup to wrap logo in .alias.
examples/out/full-invoice-ar.html Updates header markup to wrap logo in .alias.
examples/out/ar-arca-standard.html Adds ARCA doc-type “letter box” to rendered example output.
examples/out/ar-arca-standard-logo.html New rendered example output including logo + ARCA doc-type.
examples/ar-arca-standard-logo.json New example input fixture containing ar-arca-doc-type extension + logo.
components/regimes/ar/arca.templ Adds ARCADocTypeLetter templ component + helper to map doc type → A/B/C.
components/regimes/ar/arca_templ.go Generated output for the above templ changes.
components/bill/invoice.templ Adjusts titleHero to accept internal.Document, wraps supplier logo/text in .alias, and renders ARCA doc-type component.
components/bill/invoice_templ.go Generated output for the above invoice templ changes.
assets/styles/invoice.css Makes .hero flex, makes .alias flex-grow, and adds styles for .arca-doc-type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@methodofaction methodofaction requested a review from pmenendz March 17, 2026 09:37
@methodofaction
Copy link
Contributor Author

@pmenendz I deliberately changed the markup so if an invoice has a logo, it will still be contained within the .alias element (before it was either <div class="alias">Company name</div> or <img src="...">, now it's <div class="alias"><img src="..."></div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants