Fix normalization in france#753
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 333 333
Lines 17794 17797 +3
=======================================
+ Hits 16558 16561 +3
Misses 870 870
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes French CTC party identity normalization by ensuring that when a SIREN identity is generated from an existing SIRET, it also gets the required ISO/IEC 6523 scheme ID extension (since the EN16931 addon has already normalized the identities slice earlier in the pipeline).
Changes:
- Set
iso-scheme-id(iso.ExtKeySchemeID) on the newly generated SIREN identity (0002). - Update the SIREN-from-SIRET normalization test to assert the scheme ID is present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
addons/fr/ctc/org.go |
Ensures generated SIREN identities include iso.ExtKeySchemeID = "0002" at creation time. |
addons/fr/ctc/org_test.go |
Adds an assertion verifying the generated SIREN identity includes scheme ID 0002. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samlown
left a comment
There was a problem hiding this comment.
Is this really required? Feels like a direct mapping that doesn't really add much value.
Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.And if you are part of the org: