Skip to content

Fix normalization in france#753

Merged
alvarolivie merged 1 commit intomainfrom
fix-normalizations
Mar 31, 2026
Merged

Fix normalization in france#753
alvarolivie merged 1 commit intomainfrom
fix-normalizations

Conversation

@alvarolivie
Copy link
Copy Markdown
Contributor

@alvarolivie alvarolivie commented Mar 3, 2026

  • Added extension as normalization ran before and would not set it.

Pre-Review Checklist

  • Opened this PR as a draft
  • Read the CONTRIBUTING.md guide.
  • Performed a self-review of my code.
  • Added thorough tests with at least 90% code coverage.
  • Modified or created example GOBL documents to show my changes in use, if appropriate.
  • Added links to the source of the changes in tax regimes or addons, either structured or in the comments.
  • Run go generate . to ensure that the Schemas and Regime data are up to date.
  • Reviewed and fixed all linter warnings.
  • Been obsessive with pointer nil checks to avoid panics.
  • Updated the CHANGELOG.md with an overview of my changes.
  • Marked this PR as ready for review.

And if you are part of the org:

  • Requested a review from Copilot and fixed or dismissed (with a reason) all the feedback raised.
  • Requested a review from @samlown.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.05%. Comparing base (54ba861) to head (13cc5aa).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files         333      333           
  Lines       17794    17797    +3     
=======================================
+ Hits        16558    16561    +3     
  Misses        870      870           
  Partials      366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes French CTC party identity normalization by ensuring that when a SIREN identity is generated from an existing SIRET, it also gets the required ISO/IEC 6523 scheme ID extension (since the EN16931 addon has already normalized the identities slice earlier in the pipeline).

Changes:

  • Set iso-scheme-id (iso.ExtKeySchemeID) on the newly generated SIREN identity (0002).
  • Update the SIREN-from-SIRET normalization test to assert the scheme ID is present.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
addons/fr/ctc/org.go Ensures generated SIREN identities include iso.ExtKeySchemeID = "0002" at creation time.
addons/fr/ctc/org_test.go Adds an assertion verifying the generated SIREN identity includes scheme ID 0002.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alvarolivie alvarolivie marked this pull request as ready for review March 4, 2026 10:42
Copy link
Copy Markdown
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really required? Feels like a direct mapping that doesn't really add much value.

Comment thread addons/fr/ctc/org.go
@samlown samlown added the question Further information is requested label Mar 30, 2026
@alvarolivie alvarolivie requested a review from samlown March 30, 2026 12:06
Copy link
Copy Markdown
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alvarolivie alvarolivie merged commit bd5e3fb into main Mar 31, 2026
12 checks passed
@alvarolivie alvarolivie deleted the fix-normalizations branch March 31, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants