Skip to content

[WIP] Migrate addons/br/nfe and addons/br/nfse to new rules package#764

Closed
Copilot wants to merge 3 commits intorulesfrom
copilot/migrate-nfe-nfse-packages
Closed

[WIP] Migrate addons/br/nfe and addons/br/nfse to new rules package#764
Copilot wants to merge 3 commits intorulesfrom
copilot/migrate-nfe-nfse-packages

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

  • Fetch and merge latest rules branch commits (fix expr package)
  • Migrate addons/br/nfe package from validation to rules
    • Rewrite bill_invoices.go with rules-based invoice, party, address rules
    • Rewrite bill_line.go with rules for required tax categories
    • Rewrite pay.go with rules for payment instructions/advance
    • Update nfe.go: add rules.RegisterWithGuard, remove Validator field
    • Update test files to use rules.Validate() and new error messages
  • Migrate addons/br/nfse package from validation to rules
    • Rewrite bill_invoices.go with rules-based invoice, supplier, address rules
    • Rewrite bill_line.go with rules for required tax categories
    • Rewrite org_item.go with rules for item extensions
    • Rewrite tax_combo.go with rules for tax combo extensions
    • Update nfse.go: add rules.RegisterWithGuard, remove Validator field
    • Update test files to use rules.Validate() and new error messages
  • Run tests and verify all pass

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI and others added 2 commits March 20, 2026 11:17
Co-authored-by: samlown <13102+samlown@users.noreply.github.com>
@samlown
Copy link
Copy Markdown
Collaborator

samlown commented Apr 13, 2026

This was already done directly in the repo.

@samlown samlown closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants