Conversation
d5b95f0 to
6fa76fc
Compare
Test Diff ReportNothing had changed in tests. |
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if not isinstance(document, (dict, list)): | ||
| raise DocumentIsScalar(document) | ||
|
|
||
| return document |
There was a problem hiding this comment.
Duplicated ensure_not_scalar function already exists
Medium Severity
The ensure_not_scalar function is duplicated. An identical implementation already exists in yaml_ld/document_parsers/yaml_parser.py (lines 25-30). The markdown_parser.py already imports and uses the existing function from yaml_parser.py, which is the correct pattern to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


JSONDocumentParserNote
Medium Risk
Changes how JSON and JSON-LD documents are parsed and which parser is selected for common content types, which could affect existing consumers expecting YAML-style behavior or error semantics. The change is localized but impacts document loading paths.
Overview
JSON/JSON-LD documents are now parsed as JSON. This introduces
JSONDocumentParser(UTF-8 decode +json.loads, rejects scalar documents) and registers it forapplication/jsonandapplication/ld+jsonindocument_loaders/content_types.py(previously routed toYAMLDocumentParser).Bumps package version to
1.1.17and adds a minimalflake8config (max-imports = 15) insetup.cfg.Written by Cursor Bugbot for commit 928e5cb. This will update automatically on new commits. Configure here.