-
Notifications
You must be signed in to change notification settings - Fork 1
Chore-cli-required #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,28 @@ | ||
| # This file defines the 'cli-schema' command-line tool itself, | ||
| # using the canonical schema. | ||
| command: cli-schema | ||
| description: Canonical JSON Schema for declarative CLI definitions | ||
| version: '1.0.6' | ||
| cli: | ||
| command: cli-schema | ||
| description: Canonical JSON Schema for declarative CLI definitions | ||
| version: '1.0.6' | ||
|
Comment on lines
+4
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The properties name: cli-schema
description: Canonical JSON Schema for declarative CLI definitions |
||
|
|
||
| # Defines the positional arguments for the command. | ||
| arguments: | ||
| - name: filesToValidate | ||
| description: One or more files to validate against the schema. | ||
| type: string | ||
| # 'required: false' makes this argument optional, equivalent to [files...]. | ||
| # If this was 'required: true', it would be equivalent to <files...>. | ||
| required: false | ||
| variadic: true | ||
| # Defines the positional arguments for the command. | ||
| arguments: | ||
| - name: filesToValidate | ||
| description: One or more files to validate against the schema. | ||
| type: string | ||
| # 'required: false' makes this argument optional, equivalent to [files...]. | ||
| # If this was 'required: true', it would be equivalent to <files...>. | ||
| required: false | ||
| variadic: true | ||
|
|
||
| # Defines the options (flags) for the command. | ||
| # These are standard options automatically provided by commander.js. | ||
| options: | ||
| - name: help | ||
| alias: h | ||
| description: display help for command | ||
| type: boolean | ||
| - name: version | ||
| alias: V | ||
| description: output the version number | ||
| type: boolean | ||
| # Defines the options (flags) for the command. | ||
| # These are standard options automatically provided by commander.js. | ||
| options: | ||
| - name: help | ||
| alias: h | ||
| description: display help for command | ||
| type: boolean | ||
| - name: version | ||
| alias: V | ||
| description: output the version number | ||
| type: boolean | ||
|
Comment on lines
+21
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The - name: help
short: h
description: display help for command
type: boolean
- name: version
short: V
description: output the version number
type: boolean |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -126,5 +126,6 @@ | |
| ], | ||
| "additionalProperties": false | ||
| } | ||
| } | ||
| }, | ||
| "required": ["cli"] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The properties
commandandversionused here do not align with thecli.schema.json. According to the schema, the rootcliobject should have anameproperty (which is required), notcommand. Additionally, theversionproperty is not defined in the schema for thecliobject. To maintain consistency with the schema and other examples in this file, you should usenameand removeversion.