fix(schema): Add detailed reference for the root cli object#15
fix(schema): Add detailed reference for the root cli object#15ioncakephper merged 1 commit intomainfrom
cli object#15Conversation
A new subsection, 'The `cli` Object', has been added to the 'Schema Reference' in the `README.md`. This section now provides a comprehensive table detailing all properties of the top-level `cli` object, including their type and description. Properties covered include `name`, `version`, `description`, `sortCommands`, `sortOptions`, `showGlobalOptions`, `defaultConfigFile`, `fallbackConfig`, `arguments`, `options`, and `commands`. Additionally, the introductory text has been updated to clarify that the `cli` object is mandatory and that any other top-level properties existing alongside it will not be validated by the schema.
Summary of ChangesHello @ioncakephper, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for the CLI schema by providing a dedicated and detailed reference for the root Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the README.md by adding a detailed reference table for the properties of the root cli object. The changes improve the documentation significantly by providing a clear overview of the available configuration options. However, I've identified an inconsistency where the documentation includes a version property that is not actually defined in the schema/cli.schema.json. My review includes a suggestion to correct this to ensure the documentation accurately reflects the schema.
| | Property | Type | Description | | ||
| | ------------------- | --------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | ||
| | `name` | `string` | The name of your CLI application. **(Required)** | | ||
| | `version` | `string` | The version of your CLI. It is recommended to follow semantic versioning (e.g., `1.0.0`). | |
There was a problem hiding this comment.
The documentation adds a version property to the cli object's reference table. However, this property is not defined in schema/cli.schema.json. This inconsistency can be misleading for users trying to create a valid CLI definition based on the schema. To ensure the documentation accurately reflects the schema, this property should be removed from the table. If supporting a version property is desired, the JSON schema should be updated first.
A new subsection, 'The
cliObject', has been added to the 'Schema Reference' in theREADME.md. This section now provides a comprehensive table detailing all properties of the top-levelcliobject, including their type and description. Properties covered includename,version,description,sortCommands,sortOptions,showGlobalOptions,defaultConfigFile,fallbackConfig,arguments,options, andcommands.Additionally, the introductory text has been updated to clarify that the
cliobject is mandatory and that any other top-level properties existing alongside it will not be validated by the schema.