Allow user to supply where the session object lives#2
Open
jeffandersen wants to merge 2 commits intoioncreature:masterfrom
jeffandersen:master
Open
Allow user to supply where the session object lives#2jeffandersen wants to merge 2 commits intoioncreature:masterfrom jeffandersen:master
jeffandersen wants to merge 2 commits intoioncreature:masterfrom
jeffandersen:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The genesis of this is that my application uses http://passportjs.org for authentication, meaning my user's session does not live at
req.session.user.Rather than make a specific fallback for Passport, I introduced a handler which allows the developer to supply where on the request object the user data lives (in Passport's case,
req.user).