Conversation
There was a problem hiding this comment.
Wondering if it's relevant to have this template here, rather than just use what already comes with the org @ https://github.com/ionic-team/.github/blob/main/.github/pull_request_template.md (if you open a PR to main in this repo, you should already see the template).
To me it makes sense for the repo to have a PR template if it were to differ from the org one, but this one looks the exact same, unless you have another reason?
There was a problem hiding this comment.
The comment I made about the PR template applies here, and actually the argument of the templates diverging also apply here now, as there was a fix I just merged for this template (which was preventing it from showing up in repos) - ionic-team/.github#11
There was a problem hiding this comment.
The comment I made about the other templates also apply here, but this one has the extra argument that we may not even want a template on GitHub anymore, as canny is now the go-to for feature requests, so probably what we want is to link to canny instead.
As such I think this feature request template one should be removed from this repo.
| contents: write | ||
| issues: write | ||
| deployments: write | ||
| id-token: write # to enable use of OIDC for npm provenance and trusted publishing |
There was a problem hiding this comment.
Just a reminder that you need to set trusted publishing for the @capacitor/camera npm package at (requires authentication)
Didn't check if you have, but if you haven't, here's npm docs: https://docs.npmjs.com/trusted-publishers
I've done this before, so if you have questions you can ping me.
2 participants
Description