fix(SystemBars): use native safe area insets on Android#8384
fix(SystemBars): use native safe area insets on Android#8384theproducer merged 11 commits intomainfrom
Conversation
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
A few comments on stuff I noticed while looking at the existing community safe-areas plugin.
android/capacitor/src/main/java/com/getcapacitor/plugin/SystemBars.java
Outdated
Show resolved
Hide resolved
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Tested on several apps shared across different GitHub issues, as well as a few internal apps, all seems to be working well. Very nice!
|
Awesome! Thank you so much for working on this and merging it! 🚀 A few points I'd like to discuss:
Thanks again for your work on this. Cheers! |
|
I tested today's version of |
|
I had an issue with the latest code: the UI was jumping at startup because In order to programatically control the behaviour of resizing the web view or not when the keyboard changes, here is an example with a new |
Description
This PR implements native safe area inset handling as demonstrated in https://github.com/capacitor-community/safe-area
(CSS Safe Area vars are still intact for OS upstream)
Change Type
Rationale / Problems Fixed
closes #8343
closes #8329
closes #8287
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments