Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
changed the title
github-actions
bot
added
package: core
| await menu.open(); | ||
| } | ||
|
|
||
| async function showPicker() { |
There was a problem hiding this comment.
This was not replaced by ion-picker because that component doesn't apply safe area padding.
| await expect(page.locator('ion-loading')).toBeVisible(); | ||
| }); | ||
|
|
||
| test('should open a picker', async ({ page }) => { |
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
| await expect(page.locator('ion-modal app-dialog-content')).toBeVisible(); | ||
| }); | ||
|
|
||
| test('should present a picker', async ({ page }) => { |
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
thetaPC
requested review from
ShaneK and
brandyscarney
and removed request for
ShaneK
|
|
||
| <h4 id="version-9x-legacy-picker">Legacy Picker</h4> | ||
|
|
||
| - `ion-picker-legacy` and `ion-picker-legacy-column` have been removed. The legacy picker component has been replaced with a inline picker component. |
There was a problem hiding this comment.
| - `ion-picker-legacy` and `ion-picker-legacy-column` have been removed. The legacy picker component has been replaced with a inline picker component. | |
| - `ion-picker-legacy` and `ion-picker-legacy-column` have been removed. The legacy picker component has been replaced with an inline picker component. |
There was a problem hiding this comment.
Do we also need to remove the components here: https://github.com/ionic-team/ionic-framework/blob/main/packages/angular-server/src/ionic-server-module.ts
2 participants
Issue number: internal
What is the current behavior?
ion-picker-legacyandion-picker-legacy-columnare still available. They are components that have been deprecated in v8.What is the new behavior?
ion-picker-legacyandion-picker-legacy-columnfrom core for v9.ion-picker-legacyandion-picker-legacy-columnfrom the frameworks for v9.Does this introduce a breaking change?
ion-picker-legacyandion-picker-legacy-columnhave been removed. The legacy picker component has been replaced with a inline picker component.ion-picker-legacyorIonPickerLegacyshould be changed toion-pickerandIonPicker, respectively.Other information
N/A