Skip to content

fix: DatasetList.get_ids() AttributeError when delayed=True #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shreyaav18 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: DatasetList.get_ids() AttributeError when delayed=True #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a474c8
fix: add else branch in DatasetList.get_ids() for delayed=True
Shreyaav18 Feb 28, 2026
306b21f
fix: correct delayed dataset filtering in DatasetList.get_ids
Shreyaav18 Feb 28, 2026
40c9bc4
fix lint issues
Shreyaav18 Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gliderpy/fetchers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ def __init__(
)
self.search_for = search_for
self.delayed = delayed
self.dataset_ids: OptionalList = None

def get_ids(self: "DatasetList") -> list:
"""Return the allDatasets list for the glider server."""
Expand All @@ -248,9 +249,10 @@ def get_ids(self: "DatasetList") -> list:
dataset_ids = self.e.to_pandas()["datasetID"].to_list()
dataset_ids.remove("allDatasets")
if not self.delayed:
self.dataset_ids = [
dataset_ids = [
dataset_id
for dataset_id in dataset_ids
if not dataset_id.endswith("-delayed")
]
self.dataset_ids = dataset_ids
return self.dataset_ids