Skip to content

Docs/move takeAllowance.sol from wiki #3466

Draft
vivekjain23 wants to merge 6 commits intodevelopfrom
docs/move-TakeAllowance.sol-from-wiki
Draft

Docs/move takeAllowance.sol from wiki #3466
vivekjain23 wants to merge 6 commits intodevelopfrom
docs/move-TakeAllowance.sol-from-wiki

Conversation

@vivekjain23
Copy link
Copy Markdown

Description of change

This is the PR addressing moving Wiki contracts to the wasp repo.
A TakeAllowance.sol contract was added, alongside a solo test for it.

Type of change

fixes issue: #1614

How the change has been tested

A Solo test.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have selected the develop branch as the target branch
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Comment thread packages/evm/evmtest/wiki_how_tos/TakeAllowance.sol
Comment thread packages/evm/evmtest/wiki_how_tos/how_tos_test.go Outdated
Comment thread packages/evm/evmtest/wiki_how_tos/how_tos_test.go
@vivekjain23 vivekjain23 force-pushed the docs/move-TakeAllowance.sol-from-wiki branch from d347d59 to aef8c0b Compare July 11, 2024 13:14
@lucas-tortora
Copy link
Copy Markdown
Contributor

could you rename the PR to follow the guidelines on confluence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants