fix(transcribe): align timestamp conversion with UTC+1 offset - #1
Merged
Conversation
The source data in attacks.json appears to have been generated using a UTC+1 base, despite being Singapore-based. Standard UTC or UTC+8 conversions result in a 7-8 hour discrepancy. This change forces the parsed datetime to UTC+1 before converting to a timestamp, ensuring an exact match with the existing dataset (e.g., matching 1451294954).
KonWol
reviewed
Aug 12, 2026
KonWol
left a comment
KonWol
left a comment
Collaborator
There was a problem hiding this comment.
Many thanks for your PR! Indeed we did not test our code for different timezones.
| #!/usr/bin/env python3 | ||
| import gzip | ||
| import json | ||
| from datetime import datetime |
Collaborator
There was a problem hiding this comment.
Can you please fix this line to comply with isort? Then your PR will be ready for merging.
isort --profile black --filter-files -c --skip EnergyDataset/manipulateTraces/ .
ERROR: ./datasets/SWaT/transcribe.py Imports are incorrectly sorted and/or formatted.
Contributor
Author
There was a problem hiding this comment.
Hi @KonWol, thanks for the quick review!
I have just run isort to fix the import sorting and pushed the update.Thanks again!
KonWol
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source data in attacks.json appears to have been generated using a UTC+1 base, despite being Singapore-based. Standard UTC or UTC+8 conversions result in a 7-8 hour discrepancy. This change forces the parsed datetime to UTC+1 before converting to a timestamp, ensuring an exact match with the existing dataset (e.g., matching 1451294954).