Skip to content

fix: use 0666 for temp files so umask controls final permissions #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tennox wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: use 0666 for temp files so umask controls final permissions #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion util_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,17 @@ import (
)

func tempFileOnce(dir, pattern string) (*os.File, error) {
return os.CreateTemp(dir, pattern)
f, err := os.CreateTemp(dir, pattern)
if err != nil {
return nil, err
}
// os.CreateTemp hardcodes 0600; relax to 0666 so umask controls final permissions
if err := f.Chmod(0666); err != nil {
f.Close()
os.Remove(f.Name())
return nil, err
}
return f, nil
}

func readFileOnce(filename string) ([]byte, error) {
Expand Down
2 changes: 1 addition & 1 deletion util_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func tempFileOnce(dir, pattern string) (f *os.File, err error) {
nconflict := 0
for i := 0; i < 10000; i++ {
name := filepath.Join(dir, prefix+nextRandom()+suffix)
f, err = goissue34681.OpenFile(name, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0600)
f, err = goissue34681.OpenFile(name, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666)
if os.IsExist(err) {
if nconflict++; nconflict > 10 {
randmu.Lock()
Expand Down