feat(gateway): IPIP-0524 Gateway.AllowCodecConversion config option#11090
Merged
feat(gateway): IPIP-0524 Gateway.AllowCodecConversion config option#11090
Conversation
lidel
force-pushed
the
feat/ipip-0524-codec-conversion-config
branch
from
c00557b to
2a78d61
Compare
Wire up boxo's AllowCodecConversion config to control codec conversion behavior per IPIP-0524. When false (default), the gateway returns 406 Not Acceptable if the requested format doesn't match the block's codec. Clients should fetch raw blocks (`?format=raw`) and convert client-side. Ref: ipfs/specs#524 Ref: ipfs/boxo#1077 Ref: ipfs/gateway-conformance#254
lidel
force-pushed
the
feat/ipip-0524-codec-conversion-config
branch
from
2a78d61 to
60e5668
Compare
…c-conversion-config # Conflicts: # .github/workflows/gateway-conformance.yml # docs/changelogs/v0.40.md # docs/examples/kubo-as-a-library/go.mod # docs/examples/kubo-as-a-library/go.sum # go.mod # go.sum # test/dependencies/go.mod # test/dependencies/go.sum
boxo now returns an actionable hint when codec conversion is rejected: suggests fetching raw block with ?format=raw and converting client-side.
Member
Author
|
Updated:
This is low risk due to niche feature being removed and keeping opt-in flag that restores removed functionality + we have tests for both behaviors. Merging to include in Kubo 0.40 RC1 together with the other two IPIPs (#11086 and #11148). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up boxo's
AllowCodecConversionconfig to control codec conversion behavior per IPIP-0524. When false (default), the gateway returns 406 Not Acceptable if the requested format doesn't match the block's codec.Clients should fetch raw blocks (
?format=raw) and convert client-side.TODO