Skip to content

chore(docker): simplify dotnet and add nodejs dockerfile #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iplaylf2 merged 3 commits into from
Nov 18, 2025
Merged

chore(docker): simplify dotnet and add nodejs dockerfile #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f57813
add nodejs image
iplaylf2 Nov 18, 2025
75f07ac
improve images/dotnet/Dockerfile
iplaylf2 Nov 18, 2025
888655f
format images/nodejs/Dockerfile
iplaylf2 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions images/dotnet/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
FROM mcr.microsoft.com/devcontainers/base:latest AS builder

WORKDIR /builder

ADD --chown=vscode:vscode --chmod=500 https://dot.net/v1/dotnet-install.sh .


FROM mcr.microsoft.com/devcontainers/base:latest

USER vscode
Expand All @@ -13,5 +6,4 @@ ENV PATH=$PATH:$DOTNET_ROOT:$DOTNET_ROOT/tools

ARG SDK_VERSION=LTS

RUN --mount=type=bind,from=builder,source=/builder/dotnet-install.sh,target=/builder/dotnet-install.sh \
/builder/dotnet-install.sh --channel $SDK_VERSION
RUN curl -fsSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --channel $SDK_VERSION
Comment thread
iplaylf2 marked this conversation as resolved.
8 changes: 8 additions & 0 deletions images/nodejs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
FROM mcr.microsoft.com/devcontainers/base:latest
Comment thread
iplaylf2 marked this conversation as resolved.

USER vscode
ARG SDK_VERSION=""

RUN curl -fsSL https://fnm.vercel.app/install | bash
Comment thread
iplaylf2 marked this conversation as resolved.

RUN if [ -n "$SDK_VERSION" ]; then fnm install "$SDK_VERSION"; fi
Loading