fix: don't allow f32/f64 NaN or infinity#56
Merged
Merged
Conversation
vmx
force-pushed
the
minimally-encoded-cid-tag
branch
from
90e3ff1 to
97a7943
Compare
vmx
force-pushed
the
nan-inf-long
branch
2 times, most recently
from
7c46765 to
37929b4
Compare
The short f16 NaN was already erroring, but the longer f32 and f64 versions should also error. DAG-CBOR does neither support NaN, nor Infinity.
rvagg
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short f16 NaN was already erroring, but the longer f32 and f64 versions should also error. DAG-CBOR does neither support NaN, nor Infinity.