issues fixed - #24
Merged
Merged
Conversation
…in CI android/.gitignore (Flutter's default template) excluded gradlew, gradlew.bat, and gradle-wrapper.jar, on the assumption that `flutter build` always manages Gradle invocation itself. But pr-check.yml's Kotlin-test step and codeql.yml both call `./gradlew` directly, which fails with "No such file or directory" on a fresh checkout that never ran `flutter build` first — confirmed by a live CodeQL run failure just now. The Gradle wrapper is designed to be checked into version control precisely so this works without a local Gradle install; that's the correct fix here, not routing around it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
apksigner verify --print-certs actually prints "V2 Signer: certificate SHA-256 digest: <hex>" — the workflow was grepping for a "Signer iritikrajput#1 certificate SHA-256 digest" line that apksigner never produces, so $actual was always empty and the release build failed at this step every time. Verified the corrected pattern against the local release APK before pushing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Committed from Windows, where git's core.fileMode handling doesn't reliably
preserve the Unix executable bit — gradlew landed in the index as a regular
100644 file instead of 100755, so ./gradlew failed with exit 126 (" found
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean UI with all tests passed