Skip to content

Add rmw_publisher_count_non_local_matched_subscriptions#29

Merged
jfinken merged 1 commit intoirobot/humblefrom
jfinken/count_non_local_subs_unsupported
Dec 12, 2023
Merged

Add rmw_publisher_count_non_local_matched_subscriptions#29
jfinken merged 1 commit intoirobot/humblefrom
jfinken/count_non_local_subs_unsupported

Conversation

@jfinken
Copy link
Copy Markdown

@jfinken jfinken commented Dec 11, 2023

Add this method but set an error message and return RMW_RET_UNSUPPORTED

Add this method but set an error message and return RMW_RET_UNSUPPORTED
@mauropasse mauropasse self-requested a review December 11, 2023 19:48
@jfinken
Copy link
Copy Markdown
Author

jfinken commented Dec 11, 2023

Regarding the build failures. Perhaps this cannot be built with Github CI? All Github CI jobs were removed in Sept. 2022, after the tagged 1.3.3 humble branch we have here.

@alsora
Copy link
Copy Markdown
Collaborator

alsora commented Dec 12, 2023

@jfinken feel free to ignore those CI checks.
They are not "ours" and are building the repo using vanilla ROS dependencies. Our branches only work with our specific versions of the depedndencies

@jfinken
Copy link
Copy Markdown
Author

jfinken commented Dec 12, 2023

@jfinken feel free to ignore those CI checks. They are not "ours" and are building the repo using vanilla ROS dependencies. Our branches only work with our specific versions of the depedndencies

Ok sounds good, thanks @alsora. Merging.

@jfinken jfinken merged commit 18e4f4a into irobot/humble Dec 12, 2023
@jfinken jfinken deleted the jfinken/count_non_local_subs_unsupported branch December 12, 2023 03:42
@mauropasse
Copy link
Copy Markdown
Collaborator

We might want to open this PR to rmw_cyclonedds once the eProsima PRs go in ros2/rclcpp#2338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants