Allow and track multiple publisher to same topic#55
Open
eliasdc wants to merge 10 commits intoirobot-ros:masterfrom
Open
Allow and track multiple publisher to same topic#55eliasdc wants to merge 10 commits intoirobot-ros:masterfrom
eliasdc wants to merge 10 commits intoirobot-ros:masterfrom
Conversation
alsora
reviewed
Aug 19, 2020
Collaborator
alsora
left a comment
alsora
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
I like the new feature, but I have some doubts about the implementation.
eliasdc
commented
Aug 19, 2020
happens for badly configured nodes: same node name for multiple publishers sending to same topic.
removes the necessity to suffix node_name
remove set_frequency as this would add a sample resulting in a wrong total frequency.
eliasdc
force-pushed
the
multiple_publishers
branch
from
16e570e to
aaafd82
Compare
Collaborator
|
@eliasdc I want to make sure that the application performance are not affected by the change, should be able to get results tomorrow. |
Collaborator
|
I compared your branch and master on a RaspberryPi 4 using the 20 nodes topology "montblanc". I prefer to not merge the change as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to have nodes publishing to the same topic to the benchmark application.
This adds a node_name attribute to the header message to keep track of the source of the message. A tracking number is saved for each unique node_name. This fixes an issue where the tracking_number_counter received the same number multiple times and the calculation of the stats failed because of it.
Size and frequency is saved in a Stat object to allow different sizes and frequencies with multiple publishers.