Skip to content

fix(build): verify packaged runtime deps#56

Merged
isYangs merged 1 commit into
mainfrom
codex/fix-packaged-runtime-deps
May 1, 2026
Merged

fix(build): verify packaged runtime deps#56
isYangs merged 1 commit into
mainfrom
codex/fix-packaged-runtime-deps

Conversation

@isYangs
Copy link
Copy Markdown
Owner

@isYangs isYangs commented May 1, 2026

Summary

  • Include the packaged runtime dependency closure used by axios / form-data so Electron packaged apps do not miss nested modules under pnpm.
  • Add verify:package-runtime, which extracts built app.asar files and imports the packaged axios HTTP adapter plus form-data entrypoint.
  • Run the new packaged-runtime verifier in the Release workflow before artifact cleanup.
  • Route startup auto-update checks through the guarded checkForUpdates() path to avoid unhandled startup rejections when update metadata is unavailable.

Validation

  • pnpm install --frozen-lockfile --ignore-scripts
  • pnpm exec vitest run src/main/services/AppUpdater.test.ts --config vitest.config.ts
  • pnpm run test:unit:run
  • pnpm run lint
  • pnpm run typecheck
  • pnpm run test:integration:run
  • rm -rf release dist dist-electron && pnpm run build:app && pnpm exec electron-builder --mac --dir --publish=never && pnpm run verify:package-runtime
  • Launched release/0.0.1/mac-arm64/GioPic.app/Contents/MacOS/GioPic --user-data-dir=<tmp> and confirmed logger/db/plugin initialization without ERR_MODULE_NOT_FOUND or JavaScript startup crash.

@isYangs isYangs merged commit 5b0c894 into main May 1, 2026
10 checks passed
@isYangs isYangs deleted the codex/fix-packaged-runtime-deps branch May 1, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant