Skip to content

fix(build): use asar API in runtime verifier#58

Merged
isYangs merged 1 commit into
mainfrom
codex/fix-windows-runtime-verifier
May 2, 2026
Merged

fix(build): use asar API in runtime verifier#58
isYangs merged 1 commit into
mainfrom
codex/fix-windows-runtime-verifier

Conversation

@isYangs
Copy link
Copy Markdown
Owner

@isYangs isYangs commented May 2, 2026

Summary

  • Switch the packaged-runtime verifier from spawning pnpm exec asar extract to using the @electron/asar Node API directly.
  • Add @electron/asar as an explicit dev dependency so the Release workflow does not depend on transitive CLI resolution.

Root Cause

  • The first verifier fix passed on macOS, but Windows failed while extracting win-arm64-unpacked/resources/app.asar through the spawned asar CLI.
  • Using the Node API avoids Windows shell/CLI path behavior and keeps the verifier cross-platform.

Validation

  • pnpm install --frozen-lockfile --ignore-scripts
  • pnpm run verify:package-runtime
  • pnpm run lint

@isYangs isYangs merged commit 998b8d8 into main May 2, 2026
10 checks passed
@isYangs isYangs deleted the codex/fix-windows-runtime-verifier branch May 2, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant