Add watcher preopen controls and harden server shutdown#120
Open
isham703 wants to merge 1 commit intoisaacphi:mainfrom
Open
Add watcher preopen controls and harden server shutdown#120isham703 wants to merge 1 commit intoisaacphi:mainfrom
isham703 wants to merge 1 commit intoisaacphi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Swift MCP memory/process buildup observed in large workspaces by adding opt-in runtime controls and hardening shutdown behavior, while preserving existing defaults.
Changes
--watcher-preopen-on-register(defaulttrue)--watcher-preopen-max-files(default0= unlimited)--idle-timeout(default0s= disabled)PreopenOnRegistration boolPreopenMaxFiles intPreopenOnRegistration.PreopenMaxFiles(counts successful opens only).BeforeAnyhook.sync.Once) and ensure cleanup always runs when stdio loop exits.Client.Close()idempotent in LSP client to avoid repeated wait/close races.Why
In practice, duplicated MCP stacks plus registration-triggered preopen scans can create high memory pressure and process accumulation. This change gives clients an opt-out/cap for preopen and adds reliable idle/process cleanup.
Compatibility
Defaults preserve current behavior globally, so existing clients are unaffected unless they opt in.
Tests
Files
main.gointernal/watcher/interfaces.gointernal/watcher/watcher.gointernal/lsp/client.gointernal/lsp/client_close_test.gointernal/watcher/testing/mock_client.gointernal/watcher/testing/watcher_test.goREADME.md