Fix glob pattern file watcher handling#55
Closed
dbkegley wants to merge 1 commit intoisaacphi:mainfrom
Closed
Conversation
|
Pulling this into my fork at virtuald#12 |
alecbarber
pushed a commit
to affinda/mcp-language-server
that referenced
this pull request
Jul 11, 2025
From upstream [isaacphi#55](isaacphi#55)
|
Please consider this as replacement: #99 |
Author
|
Closing in favor of #99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the duplicated filewatcher logic that was causing the files to not get added to the watch list. Diagnostics were cached initially if you ask for the file explicitly but no updates were sent by the lsp because we didn't subscribe to the file watch events.
I suspect the special handling was added initially and then refactored into
matchesGlobbut the original logic was never removed.closes #54