Skip to content

Fix TypeError when processing individual .gtf files#35

Open
Saluev wants to merge 1 commit into
ishinder:mainfrom
Saluev:patch-1
Open

Fix TypeError when processing individual .gtf files#35
Saluev wants to merge 1 commit into
ishinder:mainfrom
Saluev:patch-1

Conversation

@Saluev

@Saluev Saluev commented Mar 9, 2025

Copy link
Copy Markdown

I ran EASTR the following way:

eastr --gtf .../transcripts.gtf --reference .../GCF_009914755.1_T2T-CHM13v2.0_alt_genomic.fna --bowtie2_index .../index

and got

TypeError: can only concatenate str (not "tuple") to str

in this line. I figure it's because of an incorrectly placed parenthesis. Also switched the whole line to an f-string to match the style of other code in this file.

coperni added a commit that referenced this pull request Mar 9, 2025
coperni added a commit that referenced this pull request Mar 9, 2025
@coperni

coperni commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator

Hi @Saluev : Thank you very much for the contribution. I've spoken to @ishinder and we are going to consolidate this change into a helper function to improve code readability.

@Saluev

Saluev commented Mar 9, 2025

Copy link
Copy Markdown
Author

I think it would be polite to merge contribution first, refactor second, but I'll trust that you have your reasons on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants