Skip to content

cli: introduce minimal command registry for dispatch - #10

Merged
isink17 merged 2 commits into
masterfrom
cli/optimization
Apr 22, 2026
Merged

cli: introduce minimal command registry for dispatch#10
isink17 merged 2 commits into
masterfrom
cli/optimization

Conversation

@isink17

@isink17 isink17 commented Apr 22, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CLI command dispatching logic by replacing a large switch statement in internal/cli/app.go with a command registry in a new internal/cli/commands.go file. Feedback includes addressing the unused description field in the command struct to avoid dead code and implementing duplicate detection in the registration helper to prevent silent overwrites of command names or aliases.

Comment thread internal/cli/commands.go
Comment thread internal/cli/commands.go Outdated
@isink17
isink17 merged commit a861ecf into master Apr 22, 2026
3 checks passed
@isink17
isink17 deleted the cli/optimization branch April 22, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant