cli: add canonical query command names with backward-compatible aliases - #13
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames several CLI commands to use underscores (e.g., find_symbol, find_callers, get_impact_radius), adds aliases for the previous names, and expands the get_impact_radius command with new flags and examples. Feedback suggests that using underscores is inconsistent with existing hyphenated commands and common CLI conventions. Additionally, it was noted that hardcoded error messages in runQueryCommand should be updated to match the new command names to avoid user confusion.
| name: "find_symbol", | ||
| aliases: []string{"find-symbol"}, |
There was a problem hiding this comment.
The introduction of underscores in command names (e.g., find_symbol, find_callers, get_impact_radius) is inconsistent with the existing affected-tests command and departs from common CLI naming conventions which typically use hyphens as word separators. Unless there is a specific requirement for underscores (e.g., matching a specific external API), it is recommended to use hyphens to maintain a consistent user interface across the tool.
| name: "find_symbol", | |
| aliases: []string{"find-symbol"}, | |
| name: "find-symbol", | |
| aliases: []string{"find_symbol"}, |
1 participant
No description provided.