Add Windows C++ MSBuild and PowerShell diagnostics - #3
Merged
isink17 merged 2 commits intoMay 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several enhancements, including a new PowerShell-compatible gci command, improved MSBuild diagnostic parsing with context extraction, recent event tailing in log analysis, and robust UTF-16 auto-detection. The review feedback highlights critical compilation errors caused by using the non-standard is_multiple_of method on usize. Additionally, there are valuable recommendations to optimize performance by avoiding heap allocations during byte sampling and using a HashSet instead of a Vec for O(N) deduplication. Finally, the feedback addresses correctness issues regarding case-insensitivity in glob matching and handling quoted paths with spaces during command rewriting.
isink17
added a commit
that referenced
this pull request
May 30, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
isink17
added a commit
that referenced
this pull request
May 31, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
isink17
added a commit
that referenced
this pull request
May 31, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
isink17
added a commit
that referenced
this pull request
May 31, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
isink17
added a commit
that referenced
this pull request
Jun 4, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
isink17
added a commit
that referenced
this pull request
Jun 4, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
isink17
added a commit
that referenced
this pull request
Jul 5, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
isink17
added a commit
that referenced
this pull request
Jul 5, 2026
* Add Windows C++ MSBuild and PowerShell diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Windows legacy C++ diagnostics layer on top of the existing C++/MSBuild/PowerShell handler branch.
Implemented:
rtk gcirtk read --lines A:Brtk log --events Nfor recent deduped error/assert/load eventsValidation
Local validation passed:
cargo fmt --all -- --checkcargo clippy --all-targetscargo test --allcargo build --release.\target\release\rtk.exe --version.\target\release\rtk.exe gainNotes
rtk gciintentionally supports a safe subset of PowerShell Get-ChildItem semantics. Complex variable/pipeline/quoted-path cases should avoid unsafe rewrites and fall back instead.