Fix/post grep rtk cleanups - #6
Merged
Merged
Conversation
… blocks + failed summaries, drops passing-test noise, handles ctest -V prefixes, and filters combined stdout/stderr.
…fix/post-grep-rtk-cleanups
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements and bug fixes: it updates git diff argument normalization to treat arguments containing a dot as paths if they exist, fixes log truncation in log_cmd.rs to use character count instead of byte length to properly handle multi-byte characters, and introduces a new helper function has_rtk_disabled_prefix. Feedback on the changes suggests refactoring has_rtk_disabled_prefix to avoid redundancy as a simple alias and instead move the implementation directly into it.
Address remaining review feedback from the main MR: - remove redundant has_rtk_disabled_prefix alias and call cmd_has_rtk_disabled_prefix directly - fix grep JSON capped output to use a running current_count counter - preserve non-empty JSON files/matches when capped results exist - add/keep tests for capped grep JSON output Also preserves already-merged cleanup fixes for git diff pathspec handling and Unicode-safe log truncation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected