Merged
Conversation
Introduces a shared Legend component with color swatches and adds showLegend / legendPosition props (top, bottom, left, right) to Timeline, ScatterPlot, Histogram, BarChart, and PieChart. Each chart wraps its content in a flex container so the legend and chart divide the available space cleanly without shrinking the chart area. README prop tables and CSS class reference updated; legend screenshots added. https://claude.ai/code/session_01Bf9veNX9mqfMqrCEGnujAo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Legendcomponent with color swatches that supports horizontal (top/bottom) and vertical (left/right) layoutsshowLegendandlegendPositionprops to all five charts: Timeline, ScatterPlot, Histogram, BarChart, and PieChartTest plan
npm test— all 72 tests pass (includes 8 new Legend tests)showLegendrenders a.Legendcontainer with correct swatches and labelslegendPosition="top"places legend above the chart,"bottom"below,"left"/"right"beside itshowLabels={false}