Refactor: extract shared hooks/components, add memoization#27
Merged
Conversation
Owner
islubee
commented
Apr 20, 2026
islubee
commented
- useTooltip hook: consolidates wrapperRef, tooltip state, and showTooltip/moveTooltip/hideTooltip handlers shared across all charts
- ChartLayout component: consolidates the legend+wrapper+tooltip layout pattern duplicated in every chart
- useMemo for all D3 scale and bin computations so tooltip hover re-renders do not recompute scales unnecessarily
- useCallback for all event handlers for stable references
- useMemo for legendItems, barStyle, colorScale
- Bars/Circles: add onMouseEnter/Leave/Move to propTypes
- ChartLayout/Legend/Tooltip exported from Components/index.js
- StackedBarChart: fix segment keys from index-only to key+index, add showLegend defaultProp true
- useTooltip hook: consolidates wrapperRef, tooltip state, and showTooltip/moveTooltip/hideTooltip handlers shared across all charts - ChartLayout component: consolidates the legend+wrapper+tooltip layout pattern duplicated in every chart - useMemo for all D3 scale and bin computations so tooltip hover re-renders do not recompute scales unnecessarily - useCallback for all event handlers for stable references - useMemo for legendItems, barStyle, colorScale - Bars/Circles: add onMouseEnter/Leave/Move to propTypes - ChartLayout/Legend/Tooltip exported from Components/index.js - StackedBarChart: fix segment keys from index-only to key+index, add showLegend defaultProp true https://claude.ai/code/session_01Bf9veNX9mqfMqrCEGnujAo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.