Skip to content

WIP: Feature on click callback #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lfbn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Feature on click callback #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d23b64c
WIP: Update toggle to also call callback on click
lfbn Feb 15, 2017
18cb04b
Add on click callback to element
Feb 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/readmore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ function readMore($templateCache) {
hmMoreText: '@',
hmLessText: '@',
hmDotsClass: '@',
hmLinkClass: '@'
hmLinkClass: '@',
hmOnClickCallback: '&'
},
template: $templateCache.get('readmore.template.html'),
controller: hmReadMoreController,
Expand All @@ -34,7 +35,8 @@ function readMore($templateCache) {
vm.toggle = {
dots: '...',
dotsClass: vm.hmDotsClass,
linkClass: vm.hmLinkClass
linkClass: vm.hmLinkClass,
onClickCallback: vm.hmOnClickCallback
}

// Toggle functions
Expand All @@ -58,13 +60,24 @@ function readMore($templateCache) {
vm.toggle.show = vm.moreText && vm.moreText.length > 0;
}

vm.doToggle = function () {
function doToggle() {
$log.debug('doToggle');
vm.toggle.state = !vm.toggle.state;
vm.showMoreText = !vm.showMoreText;
setCurrentToggleText();
}

function callOnClickCb() {
$log.debug('callOnClickCb');
vm.hmOnClickCallback();
}

vm.onClick = function () {
$log.debug('onClick');
doToggle();
callOnClickCb();
}

$scope.$watch('vm.hmMoreText', function (newValue, oldValue) {
if (newValue != oldValue) {
$log.debug('hmMoreText changed');
Expand Down Expand Up @@ -111,7 +124,7 @@ function readMore($templateCache) {
function setLessAndMoreText() {
$log.debug('setLessAndMoreText');
vm.lessText = $filter('limitTo')(vm.hmText, vm.hmLimit);
vm.moreText = $filter('limitTo')(vm.hmText, getMoreTextLimit());
vm.moreText = $filter('limitTo')(vm.hmText, getMoreTextLimit());
}

function initialize() {
Expand Down
2 changes: 1 addition & 1 deletion src/readmore.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@

<span name="toggle" ng-show="vm.toggle.show">
<span ng-class="vm.toggle.dotsClass" ng-show="!vm.toggle.state">{{ vm.toggle.dots }}</span>
<a ng-class="vm.toggle.linkClass" ng-click="vm.doToggle()">{{ vm.toggle.text }}</a>
<a ng-class="vm.toggle.linkClass" ng-click="vm.onClick()">{{ vm.toggle.text }}</a>
</span>