fix: replace implicit SQLAlchemy select coercions in visitors#160
Open
lightning-sagar wants to merge 2 commits into
Open
fix: replace implicit SQLAlchemy select coercions in visitors#160lightning-sagar wants to merge 2 commits into
lightning-sagar wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the SQLAlchemy SADeprecationWarning messages raised during python -m app.sta2rest.test by replacing implicit Select coercions with explicit subqueries in
api/app/sta2rest/visitors.pyWhy
The tests still passed, but SQLAlchemy was warning about the deprecation of the current query building with APIs that may be removed in future versions of SQLAlchemy. This change keeps the current behavior and makes query building compatible with newer SQLAlchemy expectations.
Related
closes #39