fix(security): harden policy expression handling#168
Open
bhudevbhanpuriya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens custom policy expression handling in the policy create/update flows.
Previously, policy conditions were validated with a small blacklist and then interpolated directly into
CREATE POLICY/ALTER POLICYSQL. Since policy predicates are SQL syntax, not bindable values, this left a brittle surface where malformed input could try to break out ofUSING (...)orWITH CHECK (...).Changes
truenetwork = 'IDROLOGIA'"unitOfMeasurement" IS NOT NULLstatus = 'active' AND public = trueSecurity Impact
This reduces SQL syntax abuse risk around row-level-security policy management.
The API no longer passes arbitrary request-provided policy text directly into policy DDL. Instead, it accepts a limited expression grammar and renders trusted SQL from parsed tokens.
Rejected examples include:
Also smoke-tested the pure policy expression renderer.
Note: full pytest execution was not run in this environment because pytest, pip, and asyncpg are not installed locally.
Compatibility
Note
PostgreSQL cannot bind an entire policy predicate as $1, because the predicate is SQL syntax rather than a data value. This PR uses a safer middle ground: parse a limited expression language and render SQL from trusted tokens.
Closes #167