fix(time-travel): validate $as_of and $from_to at API boundary#175
Open
bhudevbhanpuriya wants to merge 1 commit into
Open
fix(time-travel): validate $as_of and $from_to at API boundary#175bhudevbhanpuriya wants to merge 1 commit into
bhudevbhanpuriya wants to merge 1 commit into
Conversation
0764eb2 to
3574d3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The API supports $as_of and $from_to query parameters, but they were not validated at the request boundary.
Endpoints parsed CommonQueryParams but ignored it, forwarding raw query strings to STA2REST.convert_query().
This caused invalid inputs to fail late and inconsistently.
What’s changed
api/app/v1/endpoints/read/query_parameters.pyEnforces:
Before v After
Tests
Added unit tests in:
test/unit/test_query_parameters.pyCovers:
Why this is needed
Closes #174