fix(tests): add qc to ALL_SCHEMA_ROLES in conftest to prevent DuplicateObject on re-runs#181
Open
Vishmayraj wants to merge 1 commit into
Open
fix(tests): add qc to ALL_SCHEMA_ROLES in conftest to prevent DuplicateObject on re-runs#181Vishmayraj wants to merge 1 commit into
qc to ALL_SCHEMA_ROLES in conftest to prevent DuplicateObject on re-runs#181Vishmayraj wants to merge 1 commit into
Conversation
…cateObject on re-runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
TestAuthtests were erroring at setup withpsycopg2.errors.DuplicateObject: role "qc" already exists.Tracing the failure back, the
qcrole was introduced in the auth SQL to support Quality Control workflows (SELECT/UPDATE on Observation, INSERT on Commit), butALL_SCHEMA_ROLESin conftest was never updated to include it. This meantrecreate_databasenever cleaned upqcbetween runs, and the second run would crash whenistsos_auth.sqltried toCREATE ROLE "qc"again.Fix is a one-liner: add
"qc"toALL_SCHEMA_ROLESso the cleanup loop inrecreate_databasedrops and re-creates it along with the other roles on every test run.The commit in context is 03d3235